Track mesh dependencies in Dummy RenderingServer #102261
Merged
+60
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…freeing MeshInstances
akien-mga
added
the
cherrypick:4.3
|
@clayjohn I expect this should work as a 4.3 cherry-pick, right? |
|
I haven't checked, but I expect that it would, yes |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #86806
The root of the problem here is that there is that the mesh is getting freed before the MeshInstance. When the MeshInstance is freed, it has to flush pending updates. In that update it attempts to read info from the mesh, but the mesh is already freed. The solution is to use the dependency tracking system that already exists for this purpose.
This PR only solves the problem for MeshInstance/Mesh, but the problem exists for all the VisualInstance derived nodes.I checked out the other node types quickly and I can't recreate the problem with them. Most likely since their dependencies are of a different nature