Don't return Tree items outside visible rect #102262
Open
+96
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
reviewed
Feb 1, 2025
KoBeWi
force-pushed
the
outer_tree_is_void
branch
from
ac9f483 to
abdef36
Compare
|
Added checks and early returns to all |
kleonc
reviewed
Feb 1, 2025
KoBeWi
force-pushed
the
outer_tree_is_void
branch
from
abdef36 to
873142a
Compare
KoBeWi
force-pushed
the
outer_tree_is_void
branch
from
873142a to
c14a57a
Compare
kleonc
reviewed
Feb 1, 2025
| TreeItem *Tree::_find_item_at_pos(TreeItem *p_item, const Point2 &p_pos, int &r_column, int &r_height, int &r_section) const { | ||
| r_column = -1; | ||
| r_height = 0; | ||
| r_section = -1; |
There was a problem hiding this comment.
Suggested change
| r_section = -1; | |
| r_section = -100; |
-1 is a valid section indicator, get_drop_section_at_position returns -100 as invalid one, these should be consistent.
(and yeah, they could be constants...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102146
Likely needs some testing.