Betsy: Consolidate documentation in module folder and cleanup SCsub #102264
+13
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Jan 31, 2025
COPYRIGHT.txt
Outdated
Comment on lines
64
to
68
| Files: modules/betsy/bc1.glsl | ||
| modules/betsy/bc4.glsl | ||
| modules/betsy/bc6h.glsl | ||
| modules/betsy/CrossPlatformSettings_piece_all.glsl |
There was a problem hiding this comment.
I didn't include alpha_stitch.glsl which I don't see upstream, so I assume we wrote it.
There was a problem hiding this comment.
It's based on etc2_rgba_stitch.glsl from upstream
There was a problem hiding this comment.
Thanks, adding it too then.
Also remove unused `UavCrossPlatform_piece_all.glsl`.
akien-mga
force-pushed
the
betsy-doc-cleanup
branch
from
dbf1c2d to
ceea97f
Compare
fire
approved these changes
Jan 31, 2025
clayjohn
approved these changes
Feb 1, 2025
| @@ -1,16 +0,0 @@ | |||
| #define OGRE_imageLoad2D(inImage, iuv) imageLoad(inImage, int2(iuv)) | |||
There was a problem hiding this comment.
This reminds me, we should also remove CrossPlatformSettings_piece_all.glsl and just use GLSL directly throughout. There isn't a good reason for us to keep using the defines from Ogre
@BlueCube3310 Do you want to work on that for 4.5?
akien-mga
added
the
cherrypick:4.4
akien-mga
removed
the
cherrypick:4.4
|
Since this is just a documentation update, I think it would be good to merge for 4.4 alongside #102242 so we have a well consolidated documentation for thirdparty code in the 4.4 branch. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove unused
UavCrossPlatform_piece_all.glsl.