Fix TextEdit visible line count when setting text #102296
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
total_visible_line_count
decreases indefinitely when settingTextEdit
's text with boundary wrap mode #102279remove_range
actually removes fromp_from_line + 1
top_to_line
, it seems weird, but it is to preserve gutters on the first line I think. The line content will be replaced afterwards anyway.The
total_visible_line_count
should now be in sync with the actual text that is removed, so the future call toinvalidate_text
will calculate the change correctly.The for loop should function the same but be more clear.
remove_range
is only called from_base_remove_text
which handles validation of the arguments so it isn't needed here. The max and min functions never do anything.