Fix missing Vector4(i) and Projection in C# bindings generator #104097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
added
bug
topic:dotnet
cherrypick:4.1
cherrypick:4.2
akien-mga
approved these changes
Mar 14, 2025
akien-mga
removed
cherrypick:4.1
cherrypick:4.2
|
Thanks! |
|
Cherry-picked for 4.4.1. |
akien-mga
removed
the
cherrypick:4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to compile my 4D module with the Mono module enabled at the same time, but I found that it was impossible because I have a default argument of type
Vector4. I guess the engine doesn't have any of those.I added the missing types, and replaced the
default:case withVariant::VARIANT_MAXto ensure this does not happen again. I marked this as cherry-pick for all stable 4.x branches because this has been a problem since 4.0 and backporting this fix should have no downsides.