Skip to content

Use Math::abs to avoid ambiguity with integer abs #105394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Use Math::abs to avoid ambiguity with integer abs #105394

merged 1 commit into from
Apr 15, 2025

Conversation

@Zylann
Copy link
Contributor

@Zylann Zylann commented Apr 14, 2025

For parity with godotengine/godot-cpp#1767

@Zylann Zylann requested a review from a team as a code owner April 14, 2025 21:54
@AThousandShips AThousandShips added this to the 4.5 milestone Apr 15, 2025
@Repiteo Repiteo merged commit 29dcead into godotengine:master Apr 15, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Apr 15, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

@rburing rburing rburing approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees

No one assigned

Labels

enhancement topic:codestyle

Projects

None yet

Milestone

4.5

Development

Successfully merging this pull request may close these issues.

6 participants

@Zylann @Repiteo @dsnopek @rburing @aaronfranke @AThousandShips