SCons: Ensure scanner parses external includes #108611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate remaining thirdparty includes from `CPPPATH` to `CPPEXTPATH`
Repiteo
force-pushed
the
scons/cscanner-advanced
branch
from
2e10993 to
3f932b8
Compare
|
No longer relevant after #111331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking for solutions to enforce a specific link order for includes, I've realized that external includes are not accounted for when SCons parses dependency chains. It'll still compile just fine, but this turned out to be a big reason why several
Dependscalls were necessary. This also migrates over the remaining#thirdpartypaths toCPPEXTPATH