Skip to content

Update VisualShader on theme changes #112382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
+11 −0
Merged

Update VisualShader on theme changes #112382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions editor/shader/visual_shader_editor_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2630,6 +2630,10 @@ void VisualShaderEditor::_update_graph() {
return;
}

if (!is_inside_tree()) {
return;
}

VisualShader::Type type = get_current_shader_type();

graph->clear_connections();
Expand Down Expand Up @@ -5343,12 +5347,18 @@ void VisualShaderEditor::_notification(int p_what) {

if (is_visible_in_tree()) {
_update_graph();
} else {
theme_dirty = true;
}
update_toggle_files_button();
} break;

case NOTIFICATION_VISIBILITY_CHANGED: {
update_toggle_files_button();
if (theme_dirty && is_visible_in_tree()) {
theme_dirty = false;
_update_graph();
}
} break;

case NOTIFICATION_DRAG_BEGIN: {
Expand Down
1 change: 1 addition & 0 deletions editor/shader/visual_shader_editor_plugin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ class VisualShaderEditor : public ShaderEditor {
CheckBox *custom_mode_box = nullptr;
bool custom_mode_enabled = false;

bool theme_dirty = false;
bool pending_update_preview = false;
bool shader_error = false;
AcceptDialog *code_preview_window = nullptr;
Expand Down