Improved monitors units and colors. #12343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
reviewed
Oct 23, 2017
| switch (Performance::MonitorType((int)perf_items[i]->get_metadata(1))) { | ||
| case Performance::MONITOR_TYPE_MEMORY: { | ||
| // for the time being, going above GBs is a bad sign. | ||
| String unit = "B"; |
There was a problem hiding this comment.
yeah, i think that would make it better.
djrm
force-pushed
the
pr_improve_monitors
branch
from
413ebc4
to
a97c850
Compare
ghost
reviewed
Oct 23, 2017
editor/script_editor_debugger.cpp
Outdated
| v /= 1024.0; | ||
| } | ||
| tt += " bytes"; | ||
| vs = rtos(v) + " " + unit; |
There was a problem hiding this comment.
im not sure about that one, since that might also be applied to time measurements for them to look consistent, and currently this does not handle time units since the only ones are from the process and fixed time which are very tiny numbers, im not sure if i should put ms for the and truncate them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friendlier names for monitors data (especially for memory units), also normalized the colors of the monitors.