Fixed a bug where materials and/or meshes weren't assigned to scene on first import. #12717
Conversation
NathanWarden
force-pushed
the
material_import_fix
branch
from
3f48ecf to
33bbe32
Compare
NathanWarden
changed the title
NathanWarden
force-pushed
the
material_import_fix
branch
from
33bbe32 to
400db80
Compare
| } else { | ||
|
|
||
| ResourceSaver::save(ext_name, mat, ResourceSaver::FLAG_CHANGE_PATH); | ||
| p_materials[mat] = mat; | ||
| p_materials[mat] = ResourceLoader::load(ext_name); |
There was a problem hiding this comment.
What's the reason for this change, and the other similar ones (reloading the just-saved mat instead of just using the source one)?
There was a problem hiding this comment.
It's because if it uses the original sourced one the resulting imported mesh or scene uses a builtin material instead of the saved resource even though the import setting is set to "Files" on the initial import. I have a video of the issue in the linked bug report.
In other words, the original material is not the same material as the newly saved resource. Thus, when you go to make changes it won't overwrite the saved material even though the import setting is set to "Files", it will try and create another new one. The same issue exists with meshes that this PR fixes.
|
Before the beta hits I just want to make sure that it's clear what this fixes. I can make a video showing before and after. Actually, there's a video that I made that's in the bug report. But, I can make a video showing it after the fix. Thanks! :) |
Fixes #11452