Fixing bad index used in Space2DSW (Fixes #11695) #12757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution :) |
Fix wrong col_obj access using wrong index variable. Related with issue godotengine#11695
MateusMP
force-pushed
the
bugfix/11695
branch
from
03ceb70 to
b37e277
Compare
|
Amend done. |
|
Could you also edit the Github web PR title? |
groud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong col_obj access using wrong index variable.
The real issue was in lines 672 and 701, where the wrong index variable was being used.
It seems like this issue would affect any collision between objects with different number of colliders.
I renamed the two variable in question so they are less confusing to avoid this issue.
j to body_shape_idx
shape_idx to col_shape_idx
Hopefully this should be the right fix for the issue. If it's not, please, let me know!
(reopened because the branch name had a bad character in it...)