Shader Editor context menu and line operations and style fix #12842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
force-pushed
the
shader_editor_fix
branch
from
537848c
to
94b3e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements and fixes to Shader Editor
fixes #12702 and #12910
fixes multiple errors being highlighted, as mentioned in #11613
adds line edit operations to menu with shortcuts for
EDIT_MOVE_LINE_UP, EDIT_MOVE_LINE_DOWN, EDIT_INDENT_LEFT, EDIT_INDENT_RIGHT, EDIT_DELETE_LINE, EDIT_CLONE_DOWN, EDIT_TOGGLE_COMMENT, EDIT_COMPLETE.These were copied from script_text_editor.cppcontext-sensitive context menu (eg. can only copy when text is selected).
fixes style of shader editor to be more similar to the script editor.
also moves swap_lines from script_text_editor.cpp to text_edit.cpp