Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scene button and tab scrolling #12983

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Nov 17, 2017

Fixes #12900
Adds a Plus icon to the right of the last scene tab.
When the tab bar is full, the icon moves to be stationary right before the distraction free mode button.
Click on the icon to add a new scene.
Also, mouse wheel scrolling in Tabs.
image

@djrm
Copy link
Contributor

djrm commented Nov 17, 2017

i would dim the plus icon a bit

@groud
Copy link
Member

groud commented Nov 17, 2017

And maybe with a little bit darker color :)
Good job anyway ! 👍

@kitbdev
Copy link
Contributor Author

kitbdev commented Nov 17, 2017

Updated to dim the icon. Uses Color(0.6f, 0.6f, 0.6f, 0.8f)
image

@reduz
Copy link
Member

reduz commented Nov 17, 2017

@djrm feel free to merge if you are happy with it

@djrm
Copy link
Contributor

djrm commented Nov 17, 2017

some issues:
when you have show scripts enabled this happens, but only when there is one tab
screenshot from 2017-11-17 12-54-56

also on certain editor sizes configurations this happens
screenshot from 2017-11-17 12-58-30
notice where the plus icon is.

also i could not get the scroll to switch tab functionality to work (is there a setting)

@kitbdev
Copy link
Contributor Author

kitbdev commented Nov 18, 2017

Fixed both issues.
The mouse wheel scrolling helps navigate when the tab offset buttons are visible; when you can't see all of the tabs. It doesn't actually select another tab. (it's like scrolling to look at other tabs in FireFox)

@djrm
Copy link
Contributor

djrm commented Nov 18, 2017

@ianb96 ok great.

@djrm
Copy link
Contributor

djrm commented Nov 18, 2017

@reduz also i cant merge, so someone else has to do it

@vnen
Copy link
Member

vnen commented Nov 19, 2017

The + changes position if I restore/maximize the window and there's not enough space in the small window to show all tabs.

@kitbdev
Copy link
Contributor Author

kitbdev commented Nov 19, 2017

It turns out maximizing the window doesn't emit the resized signal like I thought it would. I update the scene tabs on NOTIFICATION_RESIZED now and the issue is fixed.

@vnen
Copy link
Member

vnen commented Nov 19, 2017

Oh, I think it should emit the resized signal when maximizing the window. But I guess this is out of the scope of this PR.

@akien-mga akien-mga merged commit 6d105ab into godotengine:master Nov 20, 2017
@kitbdev kitbdev deleted the scene_add_tab branch November 29, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants