Few fixes for asset store browser #13008
Conversation
ghost
added
|
Godot already comes with a star icon, couldn't that be used? The one displayed in the project browser for example. |
|
Ah.. word "favorite".. but it is in svg format, needs to be converted into png |
|
|
|
It definitely looks better, hope @djrm eventually gives it a lift in general :) |
|
Ok, than I done for myself :) Its not good if in beta people looking on ERROR messages in place of rating stars, even if it is impossible(for now) to rate from asset store |
|
OOps, found a bug inside 1).. needs to be fixed before merged |
|
Ok, now its looking correct, I setup thumbnail and screenshots to correct size
Ready to merge ! |
|
I also fix invalid screenshot size so
|
Not really, Godot has support for SVG and all icons are in this format, no need to convert them. |
|
Than why is make_icon method existed and called multiple times in default_theme.cpp ? It used to load png icon and I used it... |
|
I didnt find function for load icon from SVG, can someone help me or its fine to use png ? |
|
Using the header icons is discouraged, and actaually we only do that to keep the old editor theme, the thing you have to do to get icons is simply call
and you are getting the rendered SVGs, alternatively you can put an optimized version of your SVGs in editor/icons, all of them are placed under a header and then rendered in editor, so if you put an icon there called The optimization of the svg is quite important since it affects the binary size and the editor boot time. |
| // Asset store | ||
|
|
||
| theme->set_icon("RatingNoStar", "EditorIcons", make_icon(star_png)); | ||
| theme->set_icon("RatingStar", "EditorIcons", make_icon(star_active_png)); |
There was a problem hiding this comment.
not good, deafult_theme should not be touched except for bug fixes, and this is not one, check my comment on how to load icons.
| image->resize(image->get_width() * scale_ratio, image->get_height() * scale_ratio, Image::INTERPOLATE_CUBIC); | ||
| case IMAGE_QUEUE_ICON: | ||
|
|
||
| image->resize(80, 80, Image::INTERPOLATE_CUBIC); |
There was a problem hiding this comment.
this might need to be multiplied by EDSCALE, so it works in hiDPI
|
How its now ? A much cleaner I think... I applied hidpi fix as @djrm suggested |
| break; | ||
| case IMAGE_QUEUE_THUMBNAIL: | ||
|
|
||
| image->resize(134 * EDSCALE, 69 * EDSCALE, Image::INTERPOLATE_CUBIC); |
There was a problem hiding this comment.
are you sure the backend always produce thumbnails with this aspect ratio, i dont see why we should asume such thing, as far as i can tell a thumbnail should also preserve its aspect ratio, with the icon it kinda makes sense but with this im not sure.
|
And now its ok ? |
| @@ -297,7 +297,7 @@ EditorAssetLibraryItemDescription::EditorAssetLibraryItemDescription() { | |||
|
|
|||
| previews_bg = memnew(PanelContainer); | |||
| vbox->add_child(previews_bg); | |||
| previews_bg->set_custom_minimum_size(Size2(0, 85)); | |||
| previews_bg->set_custom_minimum_size(Size2(0, 101)); | |||
There was a problem hiding this comment.
every time you use sizes for GUI you have to multiply by EDSCALE, so in this case it will be
previews_bg->set_custom_minimum_size(Size2(0, 101) * EDSCALE);
|
i think its ok, well there is some code repetition but its not that bad. |
|
Nice work and thanks for your patience :) |
Set an icon size to constant 80x80, assets will be stretched to this size. I think its better be constant for all assets, cuz different sizes of different assets looks ugly
Added missed icons for rating stars(used python script for generate header)
So the result looks like
yes I fill star with gray color, cuz transparent looks very hard for eyes(on dark themes)
and(if stars is active)