Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] - Change editor_settings.tres to editor_settings-3.tres #13072

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

sersoong
Copy link
Contributor

@sersoong sersoong commented Nov 20, 2017

A change causes my 2.1 project list to be covered.
Why 3.0 must use "editor_settings.tres" name?
You have to think about the coexistence of 2.1 and 3.0
This is what happened to me with 2.1 version:
capture

@vnen
Copy link
Member

vnen commented Nov 20, 2017

It was changed in #12988 but I'm not sure why.

@sersoong
Copy link
Contributor Author

sersoong commented Nov 20, 2017

Holy sh*t..
I have to take the time to retrieve those projects.
Almost 20 projects in everywhere...

@vnen
Copy link
Member

vnen commented Nov 20, 2017

I think it should use the VERSION_MAJOR as it did before, but I'm merging this now to minimize the issue.

@vnen vnen added this to the 3.0 milestone Nov 20, 2017
@sersoong sersoong deleted the master-test2 branch November 20, 2017 03:38
@sersoong
Copy link
Contributor Author

OK,I got it.
May be you can take this #13074.

@akien-mga
Copy link
Member

A stupid change causes my 2.1 project list to be covered.

Thanks for the kind words.

The rationale for changing it was that since we were changing the directory where config is stored on most platforms, we could change back to a non-versioned name as this hardcoded -3 is ugly. But I forgot about Windows keeping the same folder, so indeed we need to keep the version number.

No need to panic and start becoming rude though, if you can't take the heat of occasional breakages in a development branch, stick to official builds.

@sersoong
Copy link
Contributor Author

I hope you can understand the shock of losing my project list.
Sorry for my rude words.
It's really disgusting to compete with 2.1 for a common name.

@akien-mga
Copy link
Member

akien-mga commented Nov 20, 2017

It's ok, I understand the stress if you had lots of 2.1 projects links and the git version wiped them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants