Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error path returned when select '..' from file dialog #13242

Closed
wants to merge 1 commit into from
Closed

Fix error path returned when select '..' from file dialog #13242

wants to merge 1 commit into from

Conversation

Geequlim
Copy link
Contributor

Fix #13203

@akien-mga akien-mga added this to the 3.0 milestone Nov 24, 2017
@akien-mga
Copy link
Member

akien-mga commented Nov 24, 2017

That doesn't seem like the right fix to me. The issue is that .. is selected by default since . was removed in #13121. CC @Krakean

@Geequlim
Copy link
Contributor Author

@akien-mga
In my opinion select .. to get the current showing directory is expect.
Of couse the checking for . could be removed.

@akien-mga
Copy link
Member

akien-mga commented Nov 24, 2017

In my opinion select .. to get the current showing directory is expect.

No, .. means "parent directory". If you select it, it's normal that you end up with the parent directory. That's why . was there in the first place. IMO #13121 should be reverted, if we don't like this Unix-style browser and want it more like Windows', we need to rethink it a bit, and that's too late for 3.0.

Alternatively, nothing should be selected by default when opening a folder, and an empty selection should behave as ..

@Geequlim
Copy link
Contributor Author

We can hide the .. too. The dialog should never select an item with . or ...
Then have to add a button to go to parent directory like Qt does.
2017-11-24 20-30-25

@akien-mga
Copy link
Member

The problem is that unlike most other file dialogs in Qt, GTK, native Windows UI, etc., we need to be able to select folders and not only files. And quite often, people will want to select a folder by browsing inside it, instead of browsing to its parent and selecting the folder in the list.

So either we have . to be able to select the folder, or we should have support for deselecting so that no selection means "current folder".

@Krakean
Copy link
Contributor

Krakean commented Nov 26, 2017

@Geequlim fixed in #13252 , take a look please, curious whether fix works fine & as expected for you.

@akien-mga
Copy link
Member

Superseded by #13252.

@akien-mga akien-mga closed this Nov 26, 2017
@Geequlim Geequlim deleted the pr-filedialog-dir-selection branch January 11, 2018 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants