Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range to anisotropic filter level #13264

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

zatherz
Copy link
Contributor

@zatherz zatherz commented Nov 25, 2017

The range is between 1 and 16 (both inclusive), with steps of value 1. The default is still 4.

@Calinou
Copy link
Member

Calinou commented Nov 25, 2017

Do non-power-of-two values even make sense? This would require custom code to be handled, though.

Perhaps an enum of some sort should be used instead (like for MSAA).

@zatherz
Copy link
Contributor Author

zatherz commented Nov 25, 2017

I thought about that, but the OpenGL spec doesn't seem to force POT, as this is the only search result for power:

It is acceptable for implementation to round 'N' up to the nearest
supported sampling rate. For example an implementation may only
support power-of-two sampling rates.

Although I'm already limiting it to 16 when an implementation could support more than that (only a minimum of 2 is specified for the max), so it might make sense to make it an enum (I even wrote some code for that while fixing this, but ultimately decided to submit this PR). Does anybody else have any inputs?

@ghost ghost added this to the 3.0 milestone Nov 25, 2017
@zatherz
Copy link
Contributor Author

zatherz commented Nov 26, 2017

Bump

@reduz reduz merged commit ea70afc into godotengine:master Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants