Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added overloads of vector parameters for shader Trig functions. #13294

Merged
merged 1 commit into from
Nov 26, 2017
Merged

Conversation

RaXaR
Copy link
Contributor

@RaXaR RaXaR commented Nov 25, 2017

Affects issue #10562

@ghost
Copy link

ghost commented Nov 26, 2017

Would you mind removing whitespace characters in blank lines?

Also please use git commit --amend and git push -f to push further changes. Thanks for contributing! (PR workflow)

@ghost ghost added this to the 3.0 milestone Nov 26, 2017
@RaXaR
Copy link
Contributor Author

RaXaR commented Nov 26, 2017

Not a problem, I removed the whitespace from the blank lines as requested.
Then ran git commit --amend and git push -f RaXaR master to send it to my fork.

Do I need to do this PR again?

@ghost
Copy link

ghost commented Nov 26, 2017

Thank you. That's fine. You don't have to redo the PR.

However, I've just noticed about double spaces in those lines you use for alignment. They cause clang-format errors.

Ammend: Removed whitespace from blank lines.
Ammend2: Removed extra spaces in an attempt to make Clang happy. :)
@RaXaR
Copy link
Contributor Author

RaXaR commented Nov 26, 2017

Remove double-spaces, let's hope Clang's panties don't get in a knot again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants