File Dialogs adjustments (v2) #13343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krakean
force-pushed
the
filedialogs_adjustments_v2
branch
from
91e5ead to
58cb059
Compare
1. Removed "..", instead you now will see "Select Current Folder" and "Select this Folder" buttons. 2. Added "go to parent folder" (^) button to Save a File dialog. 3. Tree.cpp: "nothing_selected" signal has been re-made (previous implementation, merged in godotengine#13308, wasn't optimal in context of performance) 4. Fixed issue in Project Export dialog: MODE_SAVE_FILE wasn't set when you click "Export". 5. Now you can deselect items by clicking on empty space in Open a Directory dialog.
Krakean
force-pushed
the
filedialogs_adjustments_v2
branch
from
58cb059 to
3e0ce97
Compare
|
Note that there are style issues in your commit: https://travis-ci.org/godotengine/godot/jobs/308004043 |
|
Merged manually as ad351a2 to fix style. Good job, it works fine :) |
|
@akien-mga will fix at morning, if this can't be merged manually due to this style issue. |
|
Oh, already merged. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made adjustments to open/save file dialogs according to notes from Akien (see comment #13252 (comment)), plus a bit more:
See commit message for all details.