Add customizable clips_input property to Control

[Cryszon]

Enables clips_input as a modifiable property to complement clip_contents. See https://github.com/Cryszon/godot-clips-input-example for an example project.

This allows overriding clips_input for GraphEdit and ScrollContainer, but I think the clip_ contents already does the same thing. I used the original clips_input as the name, but was wondering if it should be renamed to clip_input to be more consistent with the existing clip_contents.

This is my first time contributing to Godot so hopefully I'm doing it right. Feedback and guidance is appreciated. I posted this on Discord yesterday but didn't get a reply so I thought I'd go ahead and make the pull request.

[groud]

I would rename clips_input to is_clipping_input for consistency.

[reduz]

I don't think having this as a property is worth it, the use case is so rare that having it exposed wont make much sense.

…

On Fri, Jan 5, 2018 at 9:05 AM, Gilles Roudiere ***@***.***> wrote: I would rename clips_input to is_clipping_input for consistency. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15358 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z2xR9ekzpqoTIjbfBO6zq9DQ76CqNks5tHhANgaJpZM4RUUYv> .

[Cryszon]

Is there another way to make nodes clipped by clip_contents ignore input events? I guess you could do it in GDScript by checking if the nodes are inside the clipping control area, but it seems unnecessarily complex compared to a single flag.

I wouldn't even mind clips_input being automatically set by clip_contents since I don't see any use case where you would need clipped "hidden" nodes to accept input. That's actually how I expected the clip_contents to work in the first place.

[Cryszon]

Also, as far as the use cases go, here's a short video of my example project and what I'm trying to achieve.

[Cryszon]

I agree that it should be connected to clip_contets. I just initially assumed that clip_contents was working as intended and didn't clip input for some weird reason, which is why I added it as a separate property. I totally agree with @reduz that there's no reason to expose it separately.

Should I update this so that clip_contents also sets clips_input and remove the property?

[akien-mga]

Sorry for the delay, PRs from December/January got piled under a huge backlog due to the 3.0 release...

Should I update this so that clip_contents also sets clips_input and remove the property?

I think it would be worth discussing yes, would you update this PR for that?

[Cryszon]

Sorry I couldn't get back to this during the weekend. Thanks for the fix!