Add standardised color names to doc #15455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 8, 2018
doc/classes/@GDScript.xml
Outdated
| [/codeblock] | ||
| Supported color name : |
There was a problem hiding this comment.
Should be Supported color names: (plural, no space before : you French ;))
Nutriz
force-pushed
the
color_names.in_doc
branch
from
86ca1ef to
feef861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11164, added color names to the doc. Also added a reference to
@GDScript.ColorN()from theColorclass, because, well, it's the first place you search for creating Color from standardised names.
According to #14704 and #15435, this PR is a temporary solution, Godot 3.1 will handle standardised color in a more clean way : moving
@GDScript.ColorN()to the Color class with autocompletion or something else like color constant...