Fix Error/Success/Warning icon color #15817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, this wasnt the right fix, what this is doing is avoiding the tinting of these icons (so in white themes they will look bad), however they need to get the color from the current theme error color, the problem was that colors are somehow being corrupted |
|
those icons should be white then. isn't it? |
|
@volzhs no they have a special color (there is one for the errors, one for warnings and one for success icons) used in the color eplacement code (before resterization). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15781
Fix #15757
Those icons have their own color and it's regenerated with theme color.