Add DNS resolution in NetworkedMultiplayerEnet::create_client() #18154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
mhilbrunner
force-pushed
the
issue-12512
branch
from
6d73eaf
to
e26a301
Compare
Faless
requested changes
Apr 13, 2018
| if (p_address.is_valid_ip_address()) { | ||
| ip = p_address; | ||
| } else { | ||
| ip = IP::get_singleton()->resolve_hostname(p_address); |
There was a problem hiding this comment.
Maybe:
#ifdef GODOT_ENET
ip = IP::get_singleton()->resolve_hostname(p_address);
#else
ip = IP::get_singleton()->resolve_hostname(p_address, IP::TYPE_IPV4);
#endif
In case someone is using externally linked ENet we should try to resolve using IPv4 as IPv6 is not supported.
(not sure who uses that, but since we support it, we can try to do our best)
| @@ -119,7 +119,7 @@ class NetworkedMultiplayerENet : public NetworkedMultiplayerPeer { | |||
| virtual int get_peer_port(int p_peer_id) const; | |||
|
|
|||
| Error create_server(int p_port, int p_max_clients = 32, int p_in_bandwidth = 0, int p_out_bandwidth = 0); | |||
| Error create_client(const IP_Address &p_ip, int p_port, int p_in_bandwidth = 0, int p_out_bandwidth = 0); | |||
| Error create_client(const String &p_ip, int p_port, int p_in_bandwidth = 0, int p_out_bandwidth = 0); | |||
There was a problem hiding this comment.
I'm just being pedantic here, but can you change p_ip to p_address? (like you rightfully did in other parts 👍 )
mhilbrunner
force-pushed
the
issue-12512
branch
from
e26a301
to
b0826de
Compare
|
@Faless Thanks, fixed. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12512.
Tested & works locally. Now you can actually use domains for your server with enet! (Or "localhost" instead of "127.0.0.1", I guess)