Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RichTextLabel bug which clears its content when theme changed #19118

Closed
wants to merge 1 commit into from

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented May 23, 2018

I found this bug when working with RichTextLabel for chat in my game, it clears its content every time theme or style changed, I dont wanna touch the work logic of parse_bbcode so instead removing clear from it, I just remove this unnecessary notification, which called it and breaks a chat logic

@akien-mga
Copy link
Member

This code was added by @reduz in 93ce7d9, so it would be good to know why it was needed back then before removing it.

@Chaosus
Copy link
Member Author

Chaosus commented May 25, 2018

Its 3 years old code, and he can did some mistakes, the theme notification here is invalid by default, cuz it calls parse_bbcode which calls clear every time the theme or style changed(if bbcode enabled). I removed whole notification cuz its old and invalid and better be rewrited from scratch..

PS Ok, lets wait for @reduz review

@akien-mga
Copy link
Member

As discussed on IRC, this was due to a misuse of set_use_bbcode due to a confusing API (to be changed as part of #16863). For the time being it will be better documented in godotengine/godot-docs#1466.

@akien-mga akien-mga closed this May 25, 2018
@Chaosus Chaosus deleted the fixrichtextlabelbug branch May 25, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants