Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds occurrence auto completion #21742

Conversation

AlexHolly
Copy link
Contributor

more accurate auto completion for TextEdit contains informations about occurrences index for highlighting.

closes #21726

related #21181

please give it a good test @KoBeWi.

@KoBeWi
Copy link
Member

KoBeWi commented Sep 4, 2018

Nice! Seems to work good in most cases, although I'd probably need to use it for some time and see how it feels overall.

Minor thing, but I found a case where it doesn't work as expected:
image

@AlexHolly
Copy link
Contributor Author

AlexHolly commented Sep 4, 2018

Ah nice, I will try to fix this. Currently it orders only by word length maybe it can be optimized by order of occurrence index.

WIP
still not perfect
image

@AlexHolly AlexHolly force-pushed the add-auto-completion-occurrences branch from a510fbb to d347436 Compare September 4, 2018 23:05
more accurate auto completion for TextEdit contains informations about occurrencs index for highlighting.
testing min_amount
@AlexHolly AlexHolly force-pushed the add-auto-completion-occurrences branch from d347436 to 68ba186 Compare September 5, 2018 13:10
@akien-mga
Copy link
Member

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.

Note: If it's merged after 3.1-stable is released, this change might be considered for cherry-picking into a later 3.1.x release.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Dec 12, 2018
@akien-mga akien-mga requested review from Paulb23 and removed request for reduz April 30, 2019 15:09
@akien-mga
Copy link
Member

This would be good to review and hopefully merge first, to reduce the complexity of the huge #21181 which includes it.

Given the timing I don't think it will cut it for 3.2 though, see also #21181 (comment) about changes to the TextEdit API for editor-specific needs.

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Oct 4, 2019
@aaronfranke
Copy link
Member

@AlexHolly Has there been any progress in solving the above issues?

I'm also wondering if the find_occurrences code could be simplified. Perhaps it could be a simple wrapper around find, each iteration starting the search from after the last one's end position.

@AlexHolly
Copy link
Contributor Author

I will wait until this is resolved.

Maybe these changes should wait on the refactor described in #31739 so that it can be done with a better architecture. (#21181 (comment))

I like the split idea and will look into find_occurrences when it happens.

I think this should probably be split into separate PRs with a better separation of concerns, so that the code completion experience can be improved gradually with well tested iterations. (#21181 (comment))

@aaronfranke
Copy link
Member

Closing this PR for now, it can be re-opened (or re-created) after #31739 is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete is inaccurate due to alphabetical sorting of suggestions
6 participants