Add ONE constants to Vector2 and Vector3 #22808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha, well done. You beat me by moments. |
KellyThomas
force-pushed
the
vector-one
branch
from
1feeb43 to
d4682a3
Compare
|
I think it would also be a good idea to add them to Mono, like you did with the original constants in #20901. |
groud
changed the title
If that isn't obfuscation 🤔 |
KellyThomas
force-pushed
the
vector-one
branch
2 times, most recently
from
944d0a5 to
107c1c4
Compare
|
@akien-mga |
|
This PR is missing the documentation changes. https://github.com/godotengine/godot/blob/master/doc/classes/Vector2.xml Note that the doc for zero vectors is wrong (for some reason it's called "Null vector" instead of "Zero vector") so you could fix that up too while you're at it. |
KellyThomas
force-pushed
the
vector-one
branch
from
107c1c4 to
3b047b7
Compare
KellyThomas
force-pushed
the
vector-one
branch
from
3b047b7 to
b150ceb
Compare
|
@aaronfranke Good idea! The documentation has been added. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updates class documentation xml
fixes #22806