Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New export options in iOS #25851

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

BastiaanOlij
Copy link
Contributor

@BastiaanOlij BastiaanOlij commented Feb 13, 2019

This PR adds a number of capability switches, adds orientation settings and adds a number of privacy strings you need to set up.

This is by no way complete but I am removing the WIP status. Most of the things not implemented are things Godot currently doesn't support anyway. As there are additional entitlements related to some of the capability switches it is best we leave implementation of those until someone has a usecase and can actually test if things work as expected.

For now, this adds the ones that have an impact on what we currently do such as gamekit, in app purchases etc.

There are two reasons we add these into the export settings even though xcode allows you to toggle them after exporting:

  • when you de-select anything in xcode it will also remove the associated frameworks and dylibs, this is a problem because it means we can't link Godot. Even when not used we still have the code in our binaries.
  • if you don't have a paid developer account you don't get access to most of the capabilities including not having access to turn them off!

Both these remarks should probably be in the documentation for exporting to iOS.

Copy link
Contributor

@samgreen samgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BastiaanOlij BastiaanOlij force-pushed the ios_export_capabilities branch from f1db64a to 0f03ad3 Compare February 16, 2019 01:14
@BastiaanOlij BastiaanOlij changed the title [WIP] New export options in iOS New export options in iOS Feb 16, 2019
@akien-mga akien-mga merged commit 2374af9 into godotengine:master Feb 16, 2019
@akien-mga
Copy link
Member

Thanks!

@HEAVYPOLY
Copy link
Contributor

HEAVYPOLY commented Nov 28, 2019

I have added a usage description to Photo Library in iOS export, but did not get a permissions popup.

I'm trying to get access to OS.get_system_dir(6) "Pictures directory path" with the photo library usage description but no luck.

OS.get_system_dir(6) is working fine on android with read/write external storage permission enabled.

Is there something else required to get the photo library permissions popup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants