Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale quickhull tolerance with mesh size #26455

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Scale quickhull tolerance with mesh size #26455

merged 1 commit into from
Mar 1, 2019

Conversation

hpvb
Copy link
Member

@hpvb hpvb commented Mar 1, 2019

Taken from three.js's implementation. Tested with a wide variety of
meshes.

This fixes #21141

@hpvb hpvb added this to the 3.1 milestone Mar 1, 2019
@hpvb hpvb requested a review from reduz as a code owner March 1, 2019 20:41
akien-mga
akien-mga reviewed Mar 1, 2019
View reviewed changes
core/math/quick_hull.cpp Outdated Show resolved Hide resolved
@hpvb
Scale quickhull tolerance with mesh size
33c6b0e 
Taken from three.js's implementation. Tested with a wide variety of
meshes.
@akien-mga akien-mga merged commit 78fcbb8 into godotengine:master Mar 1, 2019
@akien-mga
Copy link
Member

Thanks!

@hpvb hpvb deleted the fix-21141 branch March 1, 2019 22:49
@akien-mga akien-mga mentioned this pull request Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

"Create convex static body/collision sibling" freezes the editor if used on sphere mesh (regression)
2 participants
@hpvb @akien-mga