Add support for left and right shift and alt #27991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be helpful to add support for the other left/right keys like Ctrl and Alt |
|
This is not bad, but should be for Godot 4.0, as it breaks compatibility. The same should be applied for alt, ctrl and meta. Masking may work with this, needs to be checked. |
Anutrix
reviewed
Jun 24, 2019
|
@aaronfranke this is still desired and I just rebased it. |
skyace65
changed the title
|
I just built this branch and I don't think I have the skill to get this fully working so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to map left or right shift key instead of just shift. Most of what I changed I got from PR #7972 and from some help from Discord. I don't usually work with C++ so I apologize if there are any obvious mistakes.
This at least partially resolves issue #3347