Fix slight issues with autocompletion and member lists in GDScript #28609
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojidar-bg
commented
May 2, 2019
| @@ -1951,7 +1951,7 @@ static void _find_identifiers_in_base(const GDScriptCompletionContext &p_context | |||
| } else { | |||
| base_type.has_type = script->get_instance_base_type() != StringName(); | |||
| base_type.kind = GDScriptParser::DataType::NATIVE; | |||
| base_type.script_type = script->get_instance_base_type(); | |||
There was a problem hiding this comment.
The glories of static typing.. and auto-coercion.
Note that get_instance_base_type returns StringName, while script_type is a Ref<Script>. How C++ manages to convert one into the other is a complete mystery to me.
Explanations are welcome!
akien-mga
reviewed
May 2, 2019
| @@ -226,7 +226,7 @@ void GDScript::get_script_method_list(List<MethodInfo> *p_list) const { | |||
|
|
|||
| const GDScript *current = this; | |||
| while (current) { | |||
| for (const Map<StringName, GDScriptFunction *>::Element *E = member_functions.front(); E; E = E->next()) { | |||
| for (const Map<StringName, GDScriptFunction *>::Element *E = current->member_functions.front(); E; E = E->next()) { | |||
There was a problem hiding this comment.
Looks like a bug that a static analysis tool might have been able to figure out :D
akien-mga
approved these changes
May 2, 2019
|
Thanks! |
|
Cherry-picked for 3.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27152
Fixes #28591