Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emitting status on one-shot particles #29937

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Jun 20, 2019

Fixes: #21794 and #17903

Updates emission to reflect that one_shot sets it to false at end of shot.

@akien-mga akien-mga added this to the 3.2 milestone Jun 21, 2019
@akien-mga akien-mga requested a review from reduz June 21, 2019 08:17
scene/3d/particles.cpp Outdated Show resolved Hide resolved
@clayjohn
Copy link
Member Author

@akien-mga Updated. :)

I ended up adding more logic than I would like, but now we will avoid any situation where we might accidentally set internal process and not be able to turn it off.

@akien-mga
Copy link
Member

Thanks!

@clayjohn clayjohn deleted the particles-one-shot-bug branch July 8, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression, unmark One Shot when Emmiting is true, doesn't restore particles emitting
2 participants