Add a uri property to LinkButton

[zaksnet]

This is useful when you want to add link buttons through code (simplifies things) and anyway without this linkButton is just a button with an underline. I tried connecting the pressed signal instead of launching the URL from the draw event but i couldn't figure it out, any guidance is appreciated. Also documented linkButton.xml

If this is going to get merged it would be nice to add:

• StyleBoxes for the rest of the states (currently only for focused exists).
• Text alignment.

I wouldn't bother otherwise since you can do all this with a button already, but since this exists, we could improve it.

EDIT: Changed keyword from Link to Url since its more proper in this case (link most of the times implies a website URL, while URL can be anything from websites, file paths to system paths or even UNC network paths). Also added launch_url to manually launch the Url. @akien-mga please review.

[aaronfranke]

@zaksnet Is this still desired? If so, it needs to be rebased on the latest master branch.

[zaksnet]

Alright this finaly seems to be working:

@Calinou !

Just as a reminder, all this PR does is adding the Url parameter for the LinkButton. This is convenient because all the user has to do is enter the url in the editor. Otherwise to get the same result you'd have to create a script and export a variable to the editor.

[zaksnet]

The errors in the editor after closing the project seem to be related to OS::get_singleton()->shell_open(url);.

ERROR: Condition "!process_map->has(p_pid)" is true. Returning: FAILED
   at: OS_Windows::kill (platform\windows\os_windows.cpp:489)

EDIT: NVM, i get them with any project when i open/close it a couple of times.

[KoBeWi]

This is useful when you want to add link buttons through code (simplifies things)

You mean like

var link = LinkButton.new()
link.url = "https://godotengine.org/"

instead of

var link = LinkButton.new()
link.connect("pressed", OS, "shell_open", ["https://godotengine.org/"])

?

btw by connecting pressed to open_url() you make it impossible to use the button for a different purpose.

[zaksnet]

@aaronfranke @Calinou This is ready for review

[HaSa1002]

Just a documentation review as I crossed this PR.

[akien-mga]

I'd suggest overriding the virtual pressed() method instead of using the signal, as done in #59810.

I'm also not convinced about the usefulness of the open_url() method. A button's function is to be pressed and that's when the URL should be opened. If users want to open the URL without pressing the button they don't really need the button in the first place, but they could just do OS.shell_open($LinkButton.url) if need be.

[akien-mga]

I force pushed an update to solve merge conflicts, and do some further improvements to the docs, and clean up of unused methods added to the header.

I also changed the url property to uri, as I think it's the more correct term for this kind of identifier which may or may not have a protocol specified. E.g. AFAIK godotengine.org would be a URI while https://godotengine.org is a URL, and both should work here. Maybe @Faless can confirm.

I don't mind changing back to url if we feel like this is still the better name.

[akien-mga]

Tested and it seems to work fine.

One thing I thought might be expected for some users would be to set the URI as tooltip for the LinkButton, but if this is implemented it might have to be opt-out (e.g. a uri_as_tooltip bool property). But let's wait first to see if some users actually request it.

Changes done.

[akien-mga]

Thanks!

[timothyqiu]

Cherry-picked for 3.6.