Path to DotNet relative to project

[hammeron-art]

For a fresh build, more specifically, if GodotTools.ProjectEditor wasn't build and there is no binaries already generated I always get this error:

ProjectExtensions.cs(3,7): error CS0246: The type or namespace name 'DotNet' could not be found (are you missing a us
ing directive or an assembly reference?) [F:\Godot\godot\modules\mono\editor\GodotTools\GodotTools.ProjectEditor\GodotT
ools.ProjectEditor.csproj]
ProjectUtils.cs(6,7): error CS0246: The type or namespace name 'DotNet' could not be found (are you missing a using d
irective or an assembly reference?) [F:\Godot\godot\modules\mono\editor\GodotTools\GodotTools.ProjectEditor\GodotTools.
ProjectEditor.csproj]

It builds fine with or without mono_glue with the correct relative HintPath.

[hammeron-art]

The actual problem was the many HintPaths. It works on Windows and the CI with a unique path to the project directory.

[neikeq]

This is needed when building the entire solution instead of a specific project. What we should do here is add conditions:

<HintPath Condition=" '$(SolutionDir)' != '' And Exists('$(SolutionDir)\packages\...') ">$(SolutionDir)\packages\...</HintPath>
<HintPath Condition=" '$(SolutionDir)' == '' Or !Exists('$(SolutionDir)\packages\...') ">$(ProjectDir)\packages\...</HintPath>

[hammeron-art]

Only GodotTools.ProjectEditor uses DotNet and has a packages.config for it. It isn't a package used for the whole solution.

[neikeq]

But when restoring the entire solution, the packages folder is created in the solution directory instead of the project directory. At least when running nuget restore, which is what SCons uses; I didn't check with msbuild /t:restore.

[hammeron-art]

It happens to me too. The solution restores a DotNet package which is not used for any project and GodotTools.ProjectEditor another DotNet specific for it. You can the details in the manage panel in VS.

[neikeq]

This is still pending. I just checked again to be sure. When running nuget restore on a solution, the packages folder is created in the solution dir. The alternative hintpaths I commented above should always work.

[akien-mga]

What's the status of this PR?

[akien-mga]

Superseded by #31770.

Thanks for the contribution nevertheless which helped find the right fix.