-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add array slice method #31172
Add array slice method #31172
Conversation
modules/gdnative/gdnative_api.json
Outdated
@@ -2933,6 +2933,17 @@ | |||
["const godot_pool_byte_array *", "p_pba"] | |||
] | |||
}, | |||
{ | |||
"name": "godot_array_slice", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be part of the Core 1.2 extension and not placed in here, as this will cause binary compatibility issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my latest push I've incremented the core api version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what I meant 😄 I meant that this entry for godot_array_slice
needs to live inside core/next/next/api
(The Core 1.2 extension) instead of the core/api
where it is currently located.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, ok 😆 sorry my bad. I've moved the slice json object into the core/next/next/api section in my latest force push and gotten rid of the change in the python script.
If you are adding the documentation, the |
Would Also, using a |
bfecd8d
to
0797426
Compare
0797426
to
5153b7a
Compare
5153b7a
to
684b44c
Compare
modules/gdnative/gdnative_api.json
Outdated
"minor": 0 | ||
}, | ||
"next": { | ||
"core": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit log should also be amended now that it's no longer bumping core version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akien-mga In my latest force push I've fixed getting rid of the indentation and ammended the commit log.
684b44c
to
f3fbdc2
Compare
modules/gdnative/gdnative_api.json
Outdated
"type": "CORE", | ||
"version": { | ||
"major": 1, | ||
"minor": 1 | ||
"minor": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still changing the indentation, causing a diff while no actual change is made to the core
definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akien-mga I see the issue now, it was not showing up in my editor very clearly. I need to increase tab size for json... it has been fixed in the latest force push.
f3fbdc2
to
757c509
Compare
Thanks! |
Closes #4715 if pythonic syntactic sugar is decided to be not needed.