Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modifier keys causing key-code mismatch on Linux/X11. #31740

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Fix modifier keys causing key-code mismatch on Linux/X11. #31740

merged 1 commit into from
Aug 29, 2019

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 28, 2019

Former part of #18020

Commit 3: [Linux/X11] Fix key-code mismatch caused by with modifier keys. (related to #18185).

Fixes #12993

@bruvzg bruvzg mentioned this pull request Aug 28, 2019
Merged
@akien-mga akien-mga added this to the 3.2 milestone Aug 28, 2019
@akien-mga
Copy link
Member

Fixes #12993

For the reference, I tried and can't reproduce that issue on Linux, but I can confirm that this commit fixes the issue reported in #18185. (Namely that pressing Shift with 7 pressed on an en_US qwerty keyboard registers the event as Ampersand, so 7 is never unpressed.)

@akien-mga akien-mga merged commit c475f89 into godotengine:master Aug 29, 2019
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the x11_mod_keys branch August 29, 2019 07:19
@qarmin qarmin mentioned this pull request Sep 24, 2019
Closed
@qarmin qarmin mentioned this pull request Oct 2, 2019
Closed
@bruvzg bruvzg mentioned this pull request Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug platform:linuxbsd topic:input
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Ctrl and Shift key events masked when one already pressed
2 participants
@bruvzg @akien-mga