Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skin support and simplified APIs to override bone position + glTF 2.0 import fixes #32275

Merged
merged 6 commits into from
Sep 23, 2019

Conversation

akien-mga
Copy link
Member

No description provided.

reduz and others added 6 commits September 18, 2019 19:46
1: Depth draw mode set for transparent materials (iFire)
2: Skeletons
  - Bone names now unique and seperate from scene names
  - Due to mixture of fake joints and joints, new bone sanitizing for names added
  - Fixed an issue where some disjoint skins were not being joined due to a logic error
  - Deterministic and Depth-first bone creation order
3: Skins
  - Removed duplicate skins when possible
4: Animations
  - Fixed invalid morph target names
…ved unused code

- Skin groups now merge more cleanly together
- Skins whose highest nodes are siblings of another skin now get merged also
- Skin nodes who have children of another skin now also fuse together
- Removed the re-rooting of IBM code, as it is no longer needed with the Skin system
GLTF2 Import Fixes - Skin(s) to Skeleton - Skin Support
@akien-mga
Copy link
Member Author

Thanks!

@akien-mga akien-mga deleted the skin_support branch September 23, 2019 13:02
@aaronfranke
Copy link
Member

This completely breaks Mono builds. The previous commit works fine. CC @neikeq

ObjectType/EditorSpatialGizmo.cs(99,71): error CS0144: Cannot create an instance of the abstract class or interface 'SkinReference' [/home/aaronfranke/workspace/godot/modules/mono/glue/Managed/Generated/GodotSharpEditor/GodotSharpEditor.csproj]

@neikeq
Copy link
Contributor

neikeq commented Sep 24, 2019

@aaronfranke This was fixed by #32307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants