Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OR_GREATER/OR_LESSER export hint for float & int range #32935

Conversation

pouleyKetchoupp
Copy link
Contributor

This change exposes the optional or_greater & or_lesser range property hints to GDScript exports.

It allows exported variables like these:

export(float, 0.0, 10.0, 0.1, OR_GREATER, OR_LESSER) var val_float
export(float, EXP, 0.0, 100.0, 0.1, OR_GREATER) var val_exp_float
export(int, 0, 10, 0.1, OR_LESSER) var val_int

@aaronfranke
Copy link
Member

@pouleyKetchoupp Is this still desired? If so, it needs to be rebased on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

@vnen How does the GDScript rewrite affect this PR?

@vnen
Copy link
Member

vnen commented Jul 10, 2020

@vnen How does the GDScript rewrite affect this PR?

The syntax for export change to use annotations and those hints are already supported for the range exports. It could potentially be added into a 3.x release but it's not relevant for master.

@pouleyKetchoupp pouleyKetchoupp deleted the range-greater-lesser-export-hint branch July 10, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants