Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W.I.P] Made 3d raycast gizmo more visible #33103

Closed
wants to merge 1 commit into from

Conversation

MarcusElg
Copy link
Contributor

@MarcusElg MarcusElg commented Oct 27, 2019

Fixed #19793
As @Calinou suggested I made it draw a box instead of a line. Possible improvements (Let me know if I should implement and give a hint on how to approach it :P):

  • Make size depend on zoom so it still looks small when zoomed in (Probably some easy to get zoom level or something that can be used)
  • Render above the axis (Feel like this is defined somewhere totally else, have not found any setZOrder or renderOnTop methouds or similar in the gizmo class)

Also I just found out that the size of the gizmo scales with the node scale :C
If anyone wants to help out then feel free to!

@MarcusElg MarcusElg changed the title Made 3d raycast gizmo more visible [W.I.P] Made 3d raycast gizmo more visible Oct 27, 2019
@Chaosus Chaosus added this to the 3.2 milestone Oct 27, 2019
@GameDevLlama
Copy link
Contributor

Good idea! Another suggestion would be to be more related to a physical ray, like having the ray drawn as small zigzags instead of a line or box?

Could look like here, but without the sine:
https://www.pngfly.com/png-lzwkqm/

@MarcusElg
Copy link
Contributor Author

MarcusElg commented Oct 28, 2019

Good idea! Another suggestion would be to be more related to a physical ray, like having the ray drawn as small zigzags instead of a line or box?
Could look like here, but without the sine:
https://www.pngfly.com/png-lzwkqm/

It's good if more people say what they prefer as you two suggest different solutions

@MarcusElg
Copy link
Contributor Author

MarcusElg commented Oct 28, 2019

Box, zigzag or arrow, what do you think readers?

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Oct 28, 2019
@Calinou
Copy link
Member

Calinou commented Oct 28, 2019

I'd go for the arrow as it should be relatively simple to draw. Look at the DirectionalLight gizmo implementation 🙂

@MarcusElg
Copy link
Contributor Author

This isn't highest priority for me right now so if anyone else wants to continue it then feel free to. Otherwise I'll finish this eventually

@MarcusElg
Copy link
Contributor Author

I'll close this for now. Maybe I'll come back to it in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raycast3D is very hard to see in editor
5 participants