Fix explain message not being stripped in release.

[Faless]

Messages coming from ERR_EXPLAIN / ERR_*_MSG macros used to strip the error explanation in release builds and was changed in a recent refactoring.

This commit restores the old behaviour (fixing release builds).

Regression from #33517

Bugsquad edit: Fixes #33600.

[akien-mga]

CC @madmiraal

[madmiraal]

I think I'm missing something. Why is stripping the error explanation in release builds the intended behaviour? Surely we would want the error explanation in the release builds too.

From what I can work out, it appears as if it's not stripped, just replaced. If the error message/explanation is an empty string, the logger code replaces it with the default error string here:

godot/core/io/logger.cpp

Lines 70 to 77 in d3a852f

	const char *err_details;
	if (p_rationale && *p_rationale)
	err_details = p_rationale;
	else
	err_details = p_code;
	logf_error("%s: %s\n", err_type, err_details);
	logf_error(" At: %s:%i:%s() - %s\n", p_file, p_line, p_function, p_code);

Are there additional loggers that are using an empty string message as a proxy to decide not to print anything?

[Calinou]

Why is stripping the error explanation in release builds the intended behaviour? Surely we would want the error explanation in the release builds too.

This is done to improve runtime performance (as assertions can be skipped) and decrease binary size (as messages aren't included in the binary) 🙂

[akien-mga]

Indeed, ignoring those on release means that we don't need to evaluate the Strings in ERR_*_MSG macros at all, which can often involve complex operations (as examplified by #33600).