Fix Visual Studio throwing C4996 warning in ustring.cpp. #33731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 19, 2019
madmiraal
force-pushed
the
fix-c4996-warning
branch
from
a104262
to
70b0fad
Compare
5 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Visual Studio throwing a C4996 warning: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead at core\ustring.cpp(147).
Also ensures that resizing the storage was successful before trying to copy the data.
It doesn't address the fact that resize() takes an int and len is a size_t or unsigned long, or that len may wrap around when incrementing, but that's for another day.