Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GDScript warning for unused class variable by default #34271

Merged

Conversation

vnen
Copy link
Member

@vnen vnen commented Dec 11, 2019

Most of the time this is not very useful, since it can't detect usages in other files.

Closes #23207.

@vnen vnen added this to the 3.2 milestone Dec 11, 2019
@vnen vnen requested a review from bojidar-bg as a code owner December 11, 2019 14:04
@akien-mga akien-mga merged commit 98c3990 into godotengine:master Dec 11, 2019
@akien-mga
Copy link
Member

Thanks!

Calinou referenced this pull request Dec 12, 2019
See #23658 (comment)
The method was implemented back when Dictionary.get(key, default) did not
exist, but now that it does we do not need a custom method in CharFXTransform.

It's a new feature in 3.2, so does not break compat with 3.1.x.
@vnen vnen deleted the gdscript-unused-class-variable-disable branch January 8, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDScript: warns that a class variable is unused while it actually is
2 participants