Exposed toplevel status as a property for spatial and canvasitem #36092

Duroxxigar · 2020-02-11T00:20:02Z

Addresses #10453

doc/classes/CanvasItem.xml

willnationsdev · 2020-09-06T05:13:33Z

Since it was last updated in February, I'd recommend rebasing this pull request. Or, if unavailable, mentioning in the related Issue that someone else should handle the PR.

akien-mga · 2020-09-30T21:57:32Z

We actually discussed this in a live Q&A today, exposing this as a property makes sense. It needs a rebase before it can be merged.

Make sure to run doctool, normally when you have setter, getter and property exposed, the setter and getter should be removed from the documentation (as the property's description is sufficient). See https://docs.godotengine.org/en/latest/community/contributing/updating_the_class_reference.html#updating-the-documentation-template

Might be worth mentioning in the docs how child nodes of a "toplevel" node behave if they are not toplevel themselves (see #24154).

See godotengine#7996.

Implement the abstraction by targeting the current VM.

`Godot` workflow is long removed in `master`, and is only found in the `3.2-android-app-bundle` branch currently. As of now Github actions has no way to show `passing` if all checks are passed but only to show the badge of each workflow individually. We can make a feature request later on but for now, we should remove the `Godot CI` badge as it reflects completely something else.

Follow-up to a61cae1.

…pupMenu rework

Instead of just the one argument that is exactly --test. The long-form arguments --test-case and --test-suite were ignored.

This is used to get a direct pointer for the data inside a Variant. Added as another class instead of in Variant directly because this should only be used in special cases, so use must be explicit.

-No new features yet -Unlike godot 3.x, sorting happens using GPU

Added request_raw to HttpRequest Added decompress_dynamic to Compression class Added decompress_dynamic to BytePoolArray Merge doc fix revert

updated variables to use size_t removed line break to make code style more consistent added conditional check to return an error if offset field is used when loading a ZIP package fixed typo formatted file added commit regarding self contained exe files handled error loging for load zip file with offset spelling tweak updated conditional statement for magic check udpated error message when load Zip file with offset is called fix CI Trying to fix CI fix CI done Added error message for loading self-contained exe with offset. Updated documentation. Fix indent final fix indent Updated documentation. fix indents Updated doc based on suggestion Final fix fixed format

Required for godotengine/godot-docs#4074 to pass, we're removing that page from the docs as part of the getting started section rewrite.

Keeps track of the order in which items are collected by _collect_ysort_children, and uses that order to break ties between items with similar Y positions.

This closes godotengine/godot-proposals#1576.

Re: Space spacing being in addition to character spacing see: * <https://github.com/godotengine/godot/blob/d7b85fbaa1fc438effe406c9d7f973749eb4e527/scene/resources/dynamic_font.cpp#L858-L859> Re: Value being able to be negative see example here: * <godotengine#38630> But also note that nodes other than `Label` may not currently render extra space spacing correctly.

Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com> Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>

Changed the documentation of distance_fade_max_distance and min to be consistent with the behavior of the code as well as the user documentation. Also noted the behavior of swapping max_distance and min_distance (where max_distance < min_distance). Fixes godotengine#36051. Co-authored-by: Clay John <claynjohn@gmail.com>

The privacy here is already private

Entering text will now start searching automatically after 0.25 seconds have passed (debounce delay). This removes the need for a separate Search button.

…iles

This closes godotengine/godot-docs#4096.

Duroxxigar · 2020-10-01T06:48:54Z

uhhh - oops. This is why you don't work on stuff so late in the night I guess. Really don't feel like fixing this PR.

Closing and just created a new one - #42448

Duroxxigar requested a review from a team as a code owner February 11, 2020 00:20

Xrayez reviewed Feb 14, 2020

View reviewed changes

doc/classes/CanvasItem.xml Outdated Show resolved Hide resolved

Calinou added enhancement topic:core labels Feb 14, 2020

Duroxxigar force-pushed the make-spatial-toplevel-property branch from 272296c to 3a0242a Compare February 14, 2020 17:05

akien-mga added this to the 4.0 milestone Sep 30, 2020

akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 30, 2020

Calinou and others added 21 commits October 1, 2020 02:17

Document RigidBodies in character mode never sleeping automatically

55b978a

See godotengine#7996.

Document how renaming the project affects the user data path

7479644

Add GDScript code generation interface

5c90c84

Implement the abstraction by targeting the current VM.

Change GDScript compiler to use codegen abstraction

1592cf2

Add GDScript disassembler

12c0a2c

Fix invalid CSV in SDL2 controller mappings DB

479c09c

Follow-up to a61cae1.

Move GDScript tests to respective folder under modules

a549738

Register GDScript test tools as test commands to run via command-line

5ec1e1e

Updated PopupMenu documentation after merge of godotengine#41640 - Po…

dee05a3

…pupMenu rework

Fix editor inspector refresh not working

fdf8080

Fix PopupMenu unresponsive on right side of menu

c382e00

Fix filtering of search results in SectionedInspector

8cf9ede

Merge python EnvironmentError, IOError and WindowsError into OSError.

b60b954

Fix doctest runner ignoring all arguments starting with --test

3b6e713

Instead of just the one argument that is exactly --test. The long-form arguments --test-case and --test-suite were ignored.

Add VariantInternal class

f653296

This is used to get a direct pointer for the data inside a Variant. Added as another class instead of in Variant directly because this should only be used in special cases, so use must be explicit.

Re-Implement GPU particles on master.

95bbcae

-No new features yet -Unlike godot 3.x, sorting happens using GPU

Fix GDScript codegen leak.

108fe7c

Fix particles shader to use built-ins

f64d59d

HTTPRequest now accepts gzip

939dce4

Added request_raw to HttpRequest Added decompress_dynamic to Compression class Added decompress_dynamic to BytePoolArray Merge doc fix revert

NathanLovato and others added 21 commits October 1, 2020 02:17

Remove link to step-by-step/animations

8901233

Required for godotengine/godot-docs#4074 to pass, we're removing that page from the docs as part of the getting started section rewrite.

Draw selected item on top of everything else

4f5d62d

Make YSort stable

edc8aee

Keeps track of the order in which items are collected by _collect_ysort_children, and uses that order to break ties between items with similar Y positions.

Allow using a comma as decimal separator in EditorSpinSlider

ec4e6b8

This closes godotengine/godot-proposals#1576.

Hides special folders in FileDialog for macOS

4e6489f

Rename the ".import" folder to ".godot/imported"

1bd7c4c

Don't warp mouse when selecting tracks

ee65223

Use the vertex colors by default in gltf.

3f7f513

doc: Some improvements to KinematicBody docs

97fd929

Co-authored-by: Marcel Admiraal <madmiraal@users.noreply.github.com> Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>

Removed unnecessary keyword, fix comment style

b42d9f8

The privacy here is already private

Automatically start searching in the asset library when entering text

9e1ab0c

Entering text will now start searching automatically after 0.25 seconds have passed (debounce delay). This removes the need for a separate Search button.

Improve appearance of [connection] and [editable] sections in .tscn f…

b6b24d5

…iles

Drag & drop 3d/2d array/cubemap texture to visual shader

5c6b5d6

Fix error message when exporting a write-only property without a setter

c8d648f

Make the pressed autokey icon red to emphasize its "recording" status

ee20385

Fixes FileSystem tree preview icon size on HiDPI

0698580

Make "function" a property of FuncRef

0ae38de

Improve the String comparison methods' documentation

f618072

This closes godotengine/godot-docs#4096.

Exposed toplevel status as a property for spatial and canvasitem

c3cf00f

Duroxxigar requested review from akien-mga, hpvb and reduz as code owners October 1, 2020 06:19

Duroxxigar closed this Oct 1, 2020

Duroxxigar mentioned this pull request Oct 1, 2020

Made toplevel a property for Node3D and CanvasItem #42448

Merged

akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Oct 1, 2020

Duroxxigar deleted the make-spatial-toplevel-property branch May 2, 2021 03:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exposed toplevel status as a property for spatial and canvasitem #36092

Exposed toplevel status as a property for spatial and canvasitem #36092

Duroxxigar commented Feb 11, 2020 •

edited

Loading

willnationsdev commented Sep 6, 2020

akien-mga commented Sep 30, 2020 •

edited

Loading

Duroxxigar commented Oct 1, 2020

Exposed toplevel status as a property for spatial and canvasitem #36092

Exposed toplevel status as a property for spatial and canvasitem #36092

Conversation

Duroxxigar commented Feb 11, 2020 • edited Loading

willnationsdev commented Sep 6, 2020

akien-mga commented Sep 30, 2020 • edited Loading

Duroxxigar commented Oct 1, 2020

Duroxxigar commented Feb 11, 2020 •

edited

Loading

akien-mga commented Sep 30, 2020 •

edited

Loading