Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve range property hints for various collision shapes #36450

Closed
wants to merge 1 commit into from
Closed

Improve range property hints for various collision shapes #36450

wants to merge 1 commit into from

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Feb 22, 2020

Closes #36419.
Helps #19242.

The current limits seem to be unreasonably high for shapes, when you drag a slider it's often too difficult to set a value which wouldn't jump from minimal size/length to a size which covers the whole viewport (meaning it only takes 4 range steps to exceed the shape's size beyond visible screen in most cases). Fine-tuning helps but doing this every time is tiresome.

The maximum ranges:

  • for 2D: 1024 pixels or greater (was 16384);
  • for 3D: 128 units or greater (exact ranges as in CSG nodes) (was 4096).

The maximum values for 2D and 3D are picked by an "equal" number of mouse-wheel scrolls it takes to fully enclose a shape for it to become visible inside the editor viewport (in most cases).

Slow stepping for 2D is taken into account: #866, so I didn't change the current step (0.5 pixels).

@Xrayez
Copy link
Contributor Author

Xrayez commented May 26, 2020

Again, merge conflicts which I'm not willing to resolve at the moment given this enhancement is not critical, so might be salvageable, but this likely needs more discussion as in #19242.

@Xrayez Xrayez reopened this Sep 20, 2020
@Xrayez
Copy link
Contributor Author

Xrayez commented Sep 20, 2020

For 3D shapes, I've just made it consistent with CSG nodes now, yet those don't allow "or_greater", which can be added too. For 2D, this is still the same as described in OP.

@akien-mga
Copy link
Member

Superseded by #59550.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleShape2D's radius is restricted to 16384
3 participants