Fix wrong selection on cloning a line down in the editor #36621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:3.x
|
CC @rxlecky I think it was probably a copy paste mistake, we can see further up in https://github.com/godotengine/godot/pull/24574/files#diff-86e49621fcb98c850c78e73214c8b478R1081 that the same logic as in this PR is used. |
Paulb23
requested changes
Feb 29, 2020
WizardOhio24
force-pushed
the
fix-wrong-selection-on-line-clone-down
branch
from
748ed4c
to
28f7432
Compare
|
Ah Ok, I understand why the formula was there. As you suggested, I've changed it so it only does the calculation if the to and from lines match, it works for a duplication on a single line now. |
Paulb23
approved these changes
Mar 1, 2020
|
Thanks! |
|
Cherry-picked for 3.2.1. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36282, the selection was wrong because the column being selected for the end of the selection was using some weird formula (it looks like the one used in finding the line the selection should be moved to).