Searching editor help centers around the found text (optional) #36866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Mar 20, 2021
There was a problem hiding this comment.
This needs to be remade against the master branch's new RichTextLabel. Also, I think you need to update the bind_methods() section to mention the default parameter and update the class reference.
For the 3.x branch, we can use the code from this pull request (make sure to save it somewhere before updating this PR). However, in that branch, the "center" default should be false to preserve the existing behavior which projects may rely on.
|
Closing as this is abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fortunately (or not?), editor help uses one big RichTextLabel to render items, instead of TextEdit as the Script canvas.
Thanks to that, fix is based on content height divided in half.
Fixes: #36861