Stop ViewportTexture error spam

[Phischermen]

The viewport path property in ViewportTexture can sometimes be invalid due to the viewport not yet being initialized. This causes an error, but the texture will still work. Thus, texture is now refreshed via call_deffered(), ensuring the viewport is initialized before refreshing the texture.

Fixes #27790

[Phischermen]

Travis says I didn't pass a static check. Is there something wrong with the format of my code? My commit?

[clayjohn]

Looks like extra whitespace after "call_deferred"

[tengkuizdihar]

Would there be an update for this one? I'm having issues when trying to make my own Label3D where the viewport always does this.

[Calinou]

Would there be an update for this one? I'm having issues when trying to make my own Label3D where the viewport always does this.

I would recommend testing the pull request and making sure it fixes the issue as described without introducing regressions on its own.

Note that this pull request targets master, not 3.x. The fix in 3.x is most likely identical, so you can cherry-pick the commit or apply the change manually on top of the 3.x branch and recompile the editor.

[tengkuizdihar]

I've done it last night and patched it myself against 3.4.2, it still doesn't work. The error messages still pops up.

CC: @Calinou

[Phischermen]

@tengkuizdihar Dang! Could you upload your project so I could debug my pull request?

[Calinou]

@tengkuizdihar Bump 🙂 See Phischerman's comment above.

[akien-mga]

Related to #64388, CC @Rindbee for cross review.

[tengkuizdihar]

Oh my god I'm sorry, it has been a year I have no idea how to replicate this issue anymore
I don't even think I have encountered this issue anymore...

[Rindbee]

Probably due to modifications elsewhere, the effect of this commit is not apparent.

In #64388, this code is for the case where the node using the ViewportTexture is instantiated before the target Viewport when running the scene.

There are some differences between opening the scene in the editor and running a scene. ViewportTexture::set_viewport_path_in_scene() is called once when opening the scene in the editor, but twice when running the scene.

[Rindbee]

This PR seems to address issues with the order of enter_tree when running scenes. But another issue was exposed.

RC3	This PR

test.zip