-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Add support for translating the class reference #37164
Conversation
- Parse `.po` files from `doc/translations/*.po` like already done with `editor/translations/*.po`. - Add logic to register a doc translation mapping in `TranslationServer` and `EditorSettings`. - Add `DTR()` to lookup the doc translation mapping (similar to `TTR()`). Strings are automatically dedented and stripped of whitespace to ensure that they would match the translation catalog. - Use `DTR()` to translate relevant strings in `EditorHelp`, `EditorInspector`, `CreateDialog`, `ConnectionsDialog`. - Small simplification to `TranslationLoaderPO`, the path argument was not really meaningful.
61be9bf
to
8c3ad2a
Compare
Added a commit (attributed to @ThakeeNathees who wrote it) to fix an issue parsing closing quotes preceded by multiple escaped blackslashes (see #37114 (comment)). |
Submitting to weblate is very troublesome. Can you make a configuration file alone? The configuration file downloads the content of weblate and can be freely modified locally. |
In this way, even if there is no translation on weblite, I can translate and use it myself. |
You can download the Weblate |
It's probably not using the |
Did you find out why? |
I was on my commute to the office... please have some patience. |
I can reproduce the issue, but I'm not sure why it happens yet. The translation does work properly, but the Chinese characters aren't display, yet the font used should support them in theory. Investigating further. |
The problem is somewhere in It's the same method used for the main editor help so both should be using the same font which supports CJK glyphs. I'll debug further to see where it breaks in that method. |
When can this feature be pushed to version 3.2? |
I don't plan to include it in 3.2, the amount of work necessary from translators to translate all the API reference is huge, and is better focused towards the next version 4.0. It's of a higher priority that translators finish translating the online documentation before attempting to translate the class reference: https://hosted.weblate.org/projects/godot-engine/godot-docs/ |
When to fix an incorrectly displayed problem? |
If you want to hire me to fix problems for you within one hour of their report, you can send me an email with a proposal. Otherwise let me do my work as time permits, thanks. |
Fixes godotengine#37164 (comment). It seems to point at a bigger theme propagation issue though.
Here you go, one day's worth of debugging a bigger issue to come up with a workaround... #39123 |
Sorry, I didn't notice the news |
What should I do? |
Nothing, the PR I opened works it around but it's not a proper fix, the real bug is #39235. |
.po
files fromdoc/translations/*.po
like already donewith
editor/translations/*.po
.TranslationServer
and
EditorSettings
.DTR()
to lookup the doc translation mapping (similar toTTR()
).DTR()
to translate relevant strings inEditorHelp
.TranslationLoaderPO
, the path argument wasnot really meaningful.
Depends on #37114 to actually generate the translation catalog and start collecting doc translations on Weblate.