Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose 'Embedded Windows Mode' as Editor and Project Settings #37391

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

dreamsComeTrue
Copy link
Contributor

@dreamsComeTrue dreamsComeTrue commented Mar 28, 2020

Exposing a bool property interface/editor/embedded_windows_mode which allows to toggle between OS-Native and Embedded windows - used to speed up process of setting that feature instead of appending --single-window in command line (many of users might not be aware of that command property yet).

@YeldhamDev
Copy link
Member

Would be nice to have an option for the project itself as well.

@dreamsComeTrue
Copy link
Contributor Author

dreamsComeTrue commented Mar 28, 2020

Would be nice to have an option for the project itself as well.

Yeah - I was actually thinking where would it suit the best - what do you think: Editor, Project, both?
And in the Project - which section? Display/Window maybe? Or Application/Editor - as it contains textbox to entry command line params?

@YeldhamDev
Copy link
Member

@dreamsComeTrue I think you misunderstood. By a project setting, I mean an option to make windows embedded for your actual game.

@dreamsComeTrue
Copy link
Contributor Author

dreamsComeTrue commented Mar 28, 2020

@dreamsComeTrue I think you misunderstood. By a project setting, I mean an option to make windows embedded for your actual game.

Yes - exactly as I understand that - currently, it steers behaviour only for Editor.
And you want to extend it, to allow Users to set that checkbox and that should affect their Projects/Games - as well as the editor.

That's why I am asking - would it be nice to have that checkbox basically duplicated for Editor Settings and Project Settings as well? Aaand - where exactly in Project Settings should it fit in your opinion?

Application/Run seems to be reasonable place I think.

@YeldhamDev
Copy link
Member

Likely display/window.

@dreamsComeTrue
Copy link
Contributor Author

Done as requested - now it is possible to change default Window rendering/behaviour separately - for Engine and for a Project as well (thanks to how Windows & MainLoop are being designed - there is no need to restart whole Editor when that setting is updated for a Project - effect is instantaneous!)

@YeldhamDev YeldhamDev changed the title Expose 'Embedded Windows Mode' as Editor Settings Expose 'Embedded Windows Mode' as Editor and Project Settings Mar 28, 2020
@dreamsComeTrue dreamsComeTrue force-pushed the embedded-windows-mode branch 2 times, most recently from 01420b5 to b820dc1 Compare March 31, 2020 18:24
@akien-mga akien-mga added this to the 4.0 milestone Apr 2, 2020
editor/editor_settings.cpp Outdated Show resolved Hide resolved
main/main.cpp Outdated Show resolved Hide resolved
main/main.cpp Outdated Show resolved Hide resolved
@dreamsComeTrue dreamsComeTrue requested review from reduz and removed request for a team April 3, 2020 19:28
@akien-mga akien-mga merged commit 9abb415 into godotengine:master Apr 4, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants