Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offset for TextureProgress progress texture #38722

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 13, 2020

@KoBeWi KoBeWi requested a review from a team as a code owner May 13, 2020 15:47
@Calinou Calinou added this to the 4.0 milestone Jan 5, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner March 9, 2021 21:26
@reduz
Copy link
Member

reduz commented Aug 30, 2021

If I have to be entirely honest, I think TextureProgress kind of became far too bloated with functions to the point we will never make everyone happy and eventually an add-on may be better fit. I understand why this is needed and it makes sense, though, so I would favor merging it.

@vnen
Copy link
Member

vnen commented Sep 1, 2021

Need to fix the XML doc to pass CI

@KoBeWi KoBeWi added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 1, 2021
@groud groud merged commit c97afc0 into godotengine:master Sep 1, 2021
@groud
Copy link
Member

groud commented Sep 1, 2021

Thanks!

@KoBeWi KoBeWi deleted the proposition branch September 1, 2021 14:21
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add offset for TextureProgress progress texture
6 participants