Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating project in a nonempty directory. #39220

Closed
wants to merge 1 commit into from
Closed

Allow creating project in a nonempty directory. #39220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions editor/project_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,25 +257,10 @@ class ProjectDialog : public ConfirmationDialog {
}

} else {
// check if the specified folder is empty, even though this is not an error, it is good to check here
d->list_dir_begin();
bool is_empty = true;
String n = d->get_next();
while (n != String()) {
if (!n.begins_with(".")) {
// Allow `.`, `..` (reserved current/parent folder names)
// and hidden files/folders to be present.
// For instance, this lets users initialize a Git repository
// and still be able to create a project in the directory afterwards.
is_empty = false;
break;
}
n = d->get_next();
}
d->list_dir_end();
// check that we won't overwrite an existing file
if (d->file_exists("project.godot") || d->file_exists("icon.png") || d->file_exists("default_env.tres")) {

if (!is_empty) {
set_message(TTR("Please choose an empty folder."), MESSAGE_ERROR);
set_message(TTR("This directory already contains a Godot project."), MESSAGE_ERROR);
memdelete(d);
get_ok()->set_disabled(true);
return "";
Expand Down